Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix comments to the base branch 2 #424

Merged
merged 6 commits into from
Jan 22, 2025
Merged

fix: fix comments to the base branch 2 #424

merged 6 commits into from
Jan 22, 2025

Conversation

SebastianElvis
Copy link
Member

Fix comments in #402

@SebastianElvis SebastianElvis mentioned this pull request Jan 20, 2025
Merged
RafilxTenfen
RafilxTenfen approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the files inside tmp-swagger-gen

Lazar955
Lazar955 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

gitferry
gitferry approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

meetrick
meetrick reviewed Jan 21, 2025
View reviewed changes
Copy link

@meetrick meetrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/zoneconcierge/keeper/grpc_query.go Show resolved Hide resolved
maurolacy
maurolacy approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

test/e2e/containers/containers.go Show resolved Hide resolved
@SebastianElvis SebastianElvis merged commit eaf20a1 into base/consumer-chain-support Jan 22, 2025
23 checks passed
@SebastianElvis SebastianElvis deleted the fix-comments-to-base-2 branch January 22, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@meetrick meetrick meetrick left review comments

@gitferry gitferry gitferry approved these changes

@maurolacy maurolacy maurolacy approved these changes

@Lazar955 Lazar955 Lazar955 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SebastianElvis @gitferry @maurolacy @Lazar955 @RafilxTenfen @meetrick